m2mBatchInsert throws "has no id yet" for an entity deleted mid-flush#1895
Open
allangsilva wants to merge 1 commit into
Open
m2mBatchInsert throws "has no id yet" for an entity deleted mid-flush#1895allangsilva wants to merge 1 commit into
allangsilva wants to merge 1 commit into
Conversation
allangsilva
commented
Jun 22, 2026
| id?: ValueGraphQLFilter<BookId>; | ||
| title?: ValueGraphQLFilter<string>; | ||
| author?: EntityGraphQLFilter<Author, AuthorId, GraphQLFilterOf<Author>, never>; | ||
| authorId?: ValueGraphQLFilter<AuthorId>; |
Collaborator
Author
There was a problem hiding this comment.
I'm unsure why I got so many codegen changes, just did yarn db 🤔
joist-codegen
joist-core
joist-graphql-codegen
joist-graphql-resolver-utils
joist-knex
joist-migration-utils
joist-orm
joist-test-utils
joist-utils
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an entity is deleted during a reaction after it's been hooked and after it was linked into a m2m, the pending join row isn't pruned. It survives into
m2mBatchInsert, which then reads the deleted entity's idTagged, but the entity was never inserted (created-then-deleted), so it has no id: