Merged
Conversation
blimmer
commented
Jun 3, 2021
| "directory": "packages/joist-orm" | ||
| }, | ||
| "engines": { | ||
| "node": "^12.17.0 || ^13.10.0 || ^14 || >= 16.0.0 < 16.2.0 || >= 16.3.0" |
Collaborator
Author
There was a problem hiding this comment.
basically - don't allow installing on 16.2.0. The 12.x and 13.x were pulled from the docs: https://nodejs.org/api/async_hooks.html#async_hooks_class_asynclocalstorage
Collaborator
There was a problem hiding this comment.
Grumble json and no in-source comments. But +1!
stephenh
approved these changes
Jun 3, 2021
| "directory": "packages/joist-orm" | ||
| }, | ||
| "engines": { | ||
| "node": "^12.17.0 || ^13.10.0 || ^14 || >= 16.0.0 < 16.2.0 || >= 16.3.0" |
Collaborator
There was a problem hiding this comment.
Grumble json and no in-source comments. But +1!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix in Node 16.3.0 should fix compatibility with Joist / jest: nodejs/node#38821