Skip to content

add support for z/OS #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabylb wants to merge 12 commits into from
Closed

add support for z/OS #520

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e941900
include zos when setting javahome
gabylb Nov 18, 2019
11d557d
remove O2 and O3 opts due to compile issue causing intermittent failure
gabylb Nov 21, 2019
bd46bc9
include zos when setting javahome
gabylb Nov 18, 2019
a965691
remove O2 and O3 opts due to compile issue causing intermittent failure
gabylb Nov 21, 2019
647ace1
replace GetContents() by GetBackingStore()
gabylb Jun 26, 2020
6c17279
zos: set compiler flags based on compiler and node versions
gabylb Jun 26, 2020
457e708
Merge branch 'node14-zos' into v8-node14-zos
gabylb Jun 27, 2020
d6ec935
link to libjvm.x on z/OS
gabylb Jul 9, 2020
b5d8614
Merge pull request #1 from ibmruntimes/v8-node14-zos
gabylb Jul 10, 2020
34bb02c
src: verify pointer before calling its method
gabylb Sep 30, 2020
6d38b70
Merge pull request #2 from ibmruntimes/destfix
gabylb Oct 1, 2020
7ecb4d1
Merge branch 'master' into node14-zos
gabylb Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: verify pointer before calling its method 
The destructor InstanceMethodCallBaton() calls m_javaObject->Unref()
which aborts when m_javaObject is NULL.

Affects at least `npm test` from `node-jdbc` npm, which aborts in
test `testcreatetable`:

(abort) [0x26C7C640]
(__cxa_end_catch) [0x2E2CC414]
(InstanceMethodCallBaton::~InstanceMethodCallBaton()+0x140) [0x2E2CD2A4]
(Nan::AsyncWorker::Destroy()@AF61_58+0x28) [0x2E2CCE4C]
(Nan::AsyncWorker::Destroy()+0x18) [0x2E2C9F12]
(Nan::AsyncExecuteComplete(uv_work_s*)+0x4e) [0x27DB5430]
...
  • Loading branch information
@gabylb
gabylb committed Sep 30, 2020
commit 34bb02cdd3fa98aa54f773de32eda80edcd6b16c
5 changes: 4 additions & 1 deletion src/methodCallBaton.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,5 +236,8 @@ InstanceMethodCallBaton::InstanceMethodCallBaton(
}

InstanceMethodCallBaton::~InstanceMethodCallBaton() {
m_javaObject->Unref();
if (m_javaObject) {
m_javaObject->Unref();
m_javaObject = NULL;
}
}