fix for ppc64le build that does not override target_arch in node-gyp#439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another possible commit that deals with this issue fully. Not sure if it's the right way to do it but it works. Rather than trying to set the target_arch variable in binding.gyp it seemed just as reasonable to leave the target architecture as ppc64 as far as node-gyp is concerned. In this version find_java_libdir.sh gets the result of
uname -mand uses that as the architecture value in the Java lib path.This works on my ppc64le environment and it's no longer necessary to override the node-gyp environment with
--target_arch=ppc64le.