Fix JENKINS-34834#54
Conversation
… teams are included
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
|
What's the purpose of re-organizing the imports? I had sorted them in alphabetical order. (e.g. from |
|
Feel free to rebase because I merged #53. |
|
🐝 @samrocketman I bet that re-org of imports is an overzealous IntelliJ ;) |
|
Eclipse organize imports, actually There were some unused imports included, so I suppose my organize imports routine had a different sorting algorithm. Sorry about that! |
|
I don't mind, I just didn't know what to make of it. It didn't follow any kind of logic that I could tell. |
|
@samrocketman is this mergeable now? Or did I need to do something? |
|
Yep, I'll merge it when I can. |
|
nice @samrocketman @apemberton eclipse? I thought we could be friends. Oh well. |
|
@michaelneale shaming me on GitHub private repo PRs is one thing, but... https://s-media-cache-ak0.pinimg.com/736x/ec/a5/01/eca501f82483cf063f73045316c8c2a1.jpg |
GitHub no longer creates a default 'Owners' group (as of 2.4 or so)
Reference: https://help.github.com/articles/about-improved-organization-permissions/
Thus, a User can belong to an Organization without being in a Team on that Org. So we need to lookup both the User's organizations and teams and merge them when calculating the user's group memberships in Jenkins.
@reviewbybees