Skip to content

Fixed JENKINS-33883 by allowing .*/cc.xml instead of only root one.#52

Merged
samrocketman merged 1 commit into
jenkinsci:masterfrom
ssbarnea:hotfix/33883
May 15, 2016
Merged

Fixed JENKINS-33883 by allowing .*/cc.xml instead of only root one.#52
samrocketman merged 1 commit into
jenkinsci:masterfrom
ssbarnea:hotfix/33883

Conversation

@ssbarnea
Copy link
Copy Markdown
Contributor

@ssbarnea ssbarnea commented May 3, 2016

No description provided.

@samrocketman
Copy link
Copy Markdown
Member

samrocketman commented May 15, 2016

I will review this, test, and merge before the next release. It will be in 0.24.

@ssbarnea
Copy link
Copy Markdown
Contributor Author

Thanks. I am already using it in production since two weeks ago and didnt had any problems.

Still, you will observe that is quite inconvenient to use a cc.xml with github organization plugin because of the multiple cc.xml files. Also the published job names are the branch names, so you may not be able to distinguish between jobs. Still this is another issue that has nothing to do with the auhentication plugin.

@samrocketman
Copy link
Copy Markdown
Member

No sure I fully comprehend because I don't use cruise control. However, if after testing it doesn't affect the functionality of the plugin in a negative way and it helps you out; then I see no reason not to include it.

@samrocketman samrocketman merged commit 87ff4fc into jenkinsci:master May 15, 2016
samrocketman added a commit that referenced this pull request May 15, 2016
@samrocketman
Copy link
Copy Markdown
Member

Released 0.24. It should be available in about 8 hrs in the update center. Or download it at https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-oauth/0.24/github-oauth-0.24.hpi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants