Fix Java 7 compatibility when running unit tests.#42
Merged
Conversation
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Member
Author
|
Code review, please. |
Member
Author
|
@cloudbeesci peer review, please. |
Member
|
Wouldn't 1.532 or so suffice? |
Member
Author
|
@daniel-beck I can test with 1.532. I chose 1.586 because that was the mentioned minimum version in JENKINS-21252. Here's a quote.
What makes you choose specifically 1.532? |
eaaaa00 to
5dc88ce
Compare
Member
Author
|
@daniel-beck I tested with 1.532. It failed to test with Java 7. cc @jcarsique code review, please. I recall we had a conversation about Java 7 compatibility. |
relates to [JENKINS-21252] fixes [JENKINS-29373]
5dc88ce to
02ef415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests now work with Java 7. Code review and testing would be much appreciated.