Fix for when user enters a badly formed github url for repo#32
Merged
samrocketman merged 1 commit intoJul 6, 2015
Conversation
Previously it threw a NullPointerException which made the jenkins UI unusable Now it treats that project as forbidden and will not show up (somewhat confusing as it "fails silently" but not sure what would be better)
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Contributor
Author
|
Fixes [JENKINS-24383] |
|
Any chance of pulling this sometime soon? |
samrocketman
added a commit
that referenced
this pull request
Jul 6, 2015
formed github url for repo
|
thank you @samrocketman ! |
Contributor
Author
|
woot @samrocketman 🚀 |
|
Thanks @samrocketman |
Member
|
😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it threw a NullPointerException which made the jenkins UI unusable
Now it treats that project as forbidden and will not show up (somewhat confusing as it "fails silently" but not sure what would be better)