Dont attempt to set email address property for a user upon login#14
Conversation
This causes performace issues when logging in.
|
Jenkins » github-oauth-plugin #43 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
can someone merge this? |
There was a problem hiding this comment.
Could probably just use hasExplicitlyConfiguredAddress() instead of getAddress() to skip the possibly expensive lookup while retaining the feature to set the email address automatically.
There was a problem hiding this comment.
@suryagaddipati can you look a look at the comment @daniel-beck left above?
There was a problem hiding this comment.
@daniel-beck @skottler i couldn't find hasExplicitlyConfiguredAddress() . Where is it?
There was a problem hiding this comment.
Same Mailer.UserProperty as getAddress(). Source code reference
There was a problem hiding this comment.
@daniel-beck oh thanks. I've changed the check to use that. Seems to address the performance issue.
…all projects and builds to find users's email address)
|
plugins » github-oauth-plugin #15 SUCCESS |
|
Can someone merge this? |
Dont attempt to set email address property for a user upon login
|
Sorry I haven't merged it earlier. Done. |
This causes performance issues when logging in.
This ultimately invokes
on each and every project.
We have hundreds of projects and this causes logging in to take forever ( more than 5 minutes) .