[JENKINS-34835] Reference GitHub teams by slug#116
Merged
Conversation
This change references teams by slug but falls back to the old behavior of referencing by name for compatibility reasons. This is so that when users upgrade they do not get authorization issues. See also: - [JENKINS-34835][JENKINS-34835] GitHub team should be referenced by slug not name [JENKINS-34835]: https://issues.jenkins-ci.org/browse/JENKINS-34835
basil
pushed a commit
that referenced
this pull request
Nov 27, 2021
* [JENKINS-34835] Use team slug for authorities if set PR #116 loads the team based on the slug if it's available but the authorities list is still using the team name. This means that you can set the team in the matrix in global security but you will then be denied access because the authorities list uses the team name. You can see this if you go to /whoAmI The team name is shown against the user. * [JENKINS-34835] Add slug to teams The GithubAuthenticationToken constructor now uses the github team slug if it's set. I've updated the tests so the slug is set here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change references teams by slug but falls back to the old behavior of referencing by name for compatibility reasons. This is so that when users upgrade they do not get authorization issues.
See also: