Minimal fix for [JENKINS-54031] GitHub OAuth plugin fails with Jenkins 2.146#103
Merged
Merged
Conversation
While testing out jenkinsci#101 it seems like there are a lot of changes to land quickly and safely. This patch aims to make a surgical fix without any cleanup or logic flow changes.
|
Thank you so much. I have compiled and tested - it has fixed the jenkins github oauth issue for my team. |
|
Any update on this? This is blocking us from upgrade to the most recent Jenkins version :( |
|
This change fixed the permission problems for my team. Thank you! |
|
@samrocketman just want to bump this back on your radar... thanks! |
Member
|
Sorry for taking so long. I'm in the midst of moving cross country so my volunteer development time is suffering. In any case, I just released 0.31 which includes this fix. |
|
Many thanks - we all appreciate your time and effort! And good luck with the move 🚚 |
Member
|
There was a lot of git spaghetti in this release 😂 https://github.com/jenkinsci/github-oauth-plugin/network |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-54031
While testing out #101 it seems like there are a lot of changes to land quickly and safely. This patch aims to make a surgical fix without any cleanup or logic flow changes.