reduce cost of NotFoundAny construction

jefimm · jefimm · commit 029d2ab546e3 · 2023-05-08T13:35:13.000+03:00
diff --git a/src/main/java/com/jsoniter/any/Any.java b/src/main/java/com/jsoniter/any/Any.java
@@ -196,7 +196,8 @@ public int size() {
 
     public Any mustBeValid() {
         if(this instanceof NotFoundAny) {
-            throw ((NotFoundAny) this).exception;
+            ((NotFoundAny) this).throwException();
+            return null;
         } else {
             return this;
         }
diff --git a/src/main/java/com/jsoniter/any/NotFoundAny.java b/src/main/java/com/jsoniter/any/NotFoundAny.java
@@ -11,21 +11,28 @@
 
 class NotFoundAny extends Any {
 
-    protected final JsonException exception;
+    private Object[] keys;
+    private int idx;
+    private Object obj, key;
+    private final int exceptionMode;
 
     public NotFoundAny(Object[] keys, int idx, Object obj) {
-        this.exception = new JsonException(String.format("Value not found: failed to get path %s, because #%s section of the path ( %s ) not found in %s",
-                Arrays.toString(keys), idx, keys[idx], obj));
+        this.keys = keys;
+        this.idx = idx;
+        this.obj = obj;
+        exceptionMode = 0;
     }
 
     public NotFoundAny(int index, Object obj) {
-        this.exception = new JsonException(String.format("Value not found: failed to get index %s from %s",
-                index, obj));
+        this.idx = index;
+        this.obj = obj;
+        exceptionMode = 1;
     }
 
     public NotFoundAny(Object key, Object obj) {
-        this.exception = new JsonException(String.format("Value not found: failed to get key %s from %s",
-                key, obj));
+        this.key = key;
+        this.obj = obj;
+        exceptionMode = 2;
     }
 
     @Override
@@ -35,12 +42,28 @@ public ValueType valueType() {
 
     @Override
     public Object object() {
-        throw exception;
+        throwException();
+        return null;
+    }
+
+    void throwException() {
+        switch (exceptionMode) {
+            case 0:
+                throw new JsonException(String.format("Value not found: failed to get path %s, because #%s section of the path ( %s ) not found in %s",
+                        Arrays.toString(keys), idx, keys[idx], obj));
+            case 1:
+                throw new JsonException(String.format("Value not found: failed to get index %s from %s",
+                        idx, obj));
+            case 2:
+                throw new JsonException(String.format("Value not found: failed to get key %s from %s",
+                        key, obj));
+        }
+        throw new JsonException();
     }
 
     @Override
     public void writeTo(JsonStream stream) throws IOException {
-        throw exception;
+        throwException();
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,8 @@ public int size() {`
`196`	`196`
`197`	`197`	`public Any mustBeValid() {`
`198`	`198`	`if(this instanceof NotFoundAny) {`
`199`		`- throw ((NotFoundAny) this).exception;`
	`199`	`+ ((NotFoundAny) this).throwException();`
	`200`	`+ return null;`
`200`	`201`	`} else {`
`201`	`202`	`return this;`
`202`	`203`	`}`