Skip to content

Add edge color#4

Open
Frou-HOS wants to merge 1 commit into
jean-moreno:masterfrom
Frou-HOS:EdgesColor
Open

Add edge color#4
Frou-HOS wants to merge 1 commit into
jean-moreno:masterfrom
Frou-HOS:EdgesColor

Conversation

@Frou-HOS

@Frou-HOS Frou-HOS commented Feb 8, 2018

Copy link
Copy Markdown

For choose Edges color

@kefniark

Copy link
Copy Markdown

Nice feature 👍

About the code there are few indentation issue (space vs tabs)

@kefniark

kefniark commented May 11, 2018

Copy link
Copy Markdown

Hum, I think there is a small issue with this PR.
This color setting works only only with 2 modes (Triangle depth & Roberts Cross)
image

The three other mode (Sobel & Triangle luminance) are unchanged
image

FragD & VertLum probably also require some modification

@jean-moreno

Copy link
Copy Markdown
Owner

Thanks for this!
I haven't looked into it in depth yet, but I'd like this repository to keep being the exact copy of the legacy image effect from Unity.

Not sure how to go about making a version with extended features on GitHub - should I make it a separate branch, or make a new repo that could be linked to this one somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants