Merged
Conversation
There is a problem with headers when a binary string is passed (like b'Authorization') I've added a function to decode such strings. It is not an elegant solution, but it works for me
Owner
|
Needs unit tests. |
This was referenced Mar 1, 2015
Contributor
|
Hi I added the unit test in #296. |
This was referenced Mar 9, 2015
|
@jcgregorio Just wondering if there is a timeline for this to be officially released? |
|
👍 @jcgregorio Would love to see a release. Happy to help make the process super easy through GitHub and Travis if you like. |
This was referenced Mar 24, 2015
|
@jcgregorio I would also love to see a release. This bug is actually preventing me from pushing new features to my project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem with headers when a binary string is passed (like b'Authorization')
"""
File "/usr/local/lib/python3.4/dist-packages/oauth2client/util.py", line 132, in positional_wrapper
return wrapped(_args, *_kwargs)
File "/usr/local/lib/python3.4/dist-packages/oauth2client/client.py", line 545, in new_request
redirections, connection_type)
File "/usr/local/lib/python3.4/dist-packages/httplib2/init.py", line 1146, in request
headers = self._normalize_headers(headers)
File "/usr/local/lib/python3.4/dist-packages/httplib2/init.py", line 1114, in _normalize_headers
return _normalize_headers(headers)
File "/usr/local/lib/python3.4/dist-packages/httplib2/init.py", line 196, in
return dict([ key.lower(), NORMALIZE_SPACE.sub(value, ' ').strip()) for (key, value) in headers.items()])
TypeError: sequence item 0: expected str instance, bytes found
Process finished with exit code 1
"""
I've added a function to decode such strings to normal ones.
It is not an elegant solution, but it works for me