Skip to content

Commit eeeefcc

Browse files
committed
Report jsdoc errors as semantic errors
This allows reporting of semantic errors as well. Semantic errors are likely to outnumber syntactic errors, so it's valuable not to block semantic errors on a few syntactic errors.
1 parent cc0f923 commit eeeefcc

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

src/compiler/program.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1227,9 +1227,6 @@ namespace ts {
12271227
if (isSourceFileJavaScript(sourceFile)) {
12281228
if (!sourceFile.additionalSyntacticDiagnostics) {
12291229
sourceFile.additionalSyntacticDiagnostics = getJavaScriptSyntacticDiagnosticsForFile(sourceFile);
1230-
if (isCheckJsEnabledForFile(sourceFile, options)) {
1231-
sourceFile.additionalSyntacticDiagnostics = concatenate(sourceFile.additionalSyntacticDiagnostics, sourceFile.jsDocDiagnostics);
1232-
}
12331230
}
12341231
return concatenate(sourceFile.additionalSyntacticDiagnostics, sourceFile.parseDiagnostics);
12351232
}
@@ -1283,8 +1280,10 @@ namespace ts {
12831280
const checkDiagnostics = includeBindAndCheckDiagnostics ? typeChecker.getDiagnostics(sourceFile, cancellationToken) : emptyArray;
12841281
const fileProcessingDiagnosticsInFile = fileProcessingDiagnostics.getDiagnostics(sourceFile.fileName);
12851282
const programDiagnosticsInFile = programDiagnostics.getDiagnostics(sourceFile.fileName);
1286-
1287-
const diagnostics = bindDiagnostics.concat(checkDiagnostics, fileProcessingDiagnosticsInFile, programDiagnosticsInFile);
1283+
let diagnostics = bindDiagnostics.concat(checkDiagnostics, fileProcessingDiagnosticsInFile, programDiagnosticsInFile);
1284+
if (isCheckJsEnabledForFile(sourceFile, options)) {
1285+
diagnostics = concatenate(diagnostics, sourceFile.jsDocDiagnostics);
1286+
}
12881287
return filter(diagnostics, shouldReportDiagnostic);
12891288
});
12901289
}

0 commit comments

Comments
 (0)