Merge pull request microsoft#27203 from sbaidon/signatureHelpInAdjacentBlockBody

DanielRosenwasser · web-flow · commit 84749493369c · 2018-10-07T23:07:59.000-07:00
Fix signature help not showing in block body bug
diff --git a/src/services/signatureHelp.ts b/src/services/signatureHelp.ts
@@ -38,7 +38,8 @@ namespace ts.SignatureHelp {
             return undefined;
         }
 
-        const argumentInfo = getContainingArgumentInfo(startingToken, position, sourceFile, typeChecker);
+        const isManuallyInvoked = !!triggerReason && triggerReason.kind === "invoked";
+        const argumentInfo = getContainingArgumentInfo(startingToken, position, sourceFile, typeChecker, isManuallyInvoked);
         if (!argumentInfo) return undefined;
 
         cancellationToken.throwIfCancellationRequested();
@@ -450,8 +451,8 @@ namespace ts.SignatureHelp {
         return createTextSpan(applicableSpanStart, applicableSpanEnd - applicableSpanStart);
     }
 
-    function getContainingArgumentInfo(node: Node, position: number, sourceFile: SourceFile, checker: TypeChecker): ArgumentListInfo | undefined {
-        for (let n = node; !isBlock(n) && !isSourceFile(n); n = n.parent) {
+    function getContainingArgumentInfo(node: Node, position: number, sourceFile: SourceFile, checker: TypeChecker, isManuallyInvoked: boolean): ArgumentListInfo | undefined {
+        for (let n = node; isManuallyInvoked || (!isBlock(n) && !isSourceFile(n)); n = n.parent) {
             // If the node is not a subspan of its parent, this is a big problem.
             // There have been crashes that might be caused by this violation.
             Debug.assert(rangeContainsRange(n.parent, n), "Not a subspan", () => `Child: ${Debug.showSyntaxKind(n)}, parent: ${Debug.showSyntaxKind(n.parent)}`);
diff --git a/tests/cases/fourslash/signatureHelpInAdjacentBlockBody.ts b/tests/cases/fourslash/signatureHelpInAdjacentBlockBody.ts
@@ -0,0 +1,15 @@
+/// <reference path="fourslash.ts" />
+
+////declare function foo(...args);
+////
+////foo(() => {/*1*/}/*2*/)
+
+goTo.marker("1");
+verify.signatureHelpPresentForTriggerReason({
+    kind: "invoked",
+});
+
+goTo.marker("2");
+verify.signatureHelpPresentForTriggerReason({
+    kind: "invoked",
+});
