Skip to content

Use a binary string to compare the auth method#45

Merged
jaysonsantos merged 2 commits into
jaysonsantos:masterfrom
SixiemeEtage:fix-python3-support
Nov 26, 2015
Merged

Use a binary string to compare the auth method#45
jaysonsantos merged 2 commits into
jaysonsantos:masterfrom
SixiemeEtage:fix-python3-support

Conversation

@dulacp

@dulacp dulacp commented Nov 23, 2015

Copy link
Copy Markdown
Contributor

Otherwise it will fail if using Python 3.x, with the TypeError exception : Type str doesn't support the buffer API.

Cheers

@dulacp dulacp force-pushed the fix-python3-support branch from fbf5a29 to 75c404e Compare November 23, 2015 17:27
@jaysonsantos

Copy link
Copy Markdown
Owner

Hey @dulaccc, sorry I could not write earlier.
Thank you for this.
Do you need a new version bump?

jaysonsantos added a commit that referenced this pull request Nov 26, 2015
Use a binary string to compare the auth method
@jaysonsantos jaysonsantos merged commit 4fa1b25 into jaysonsantos:master Nov 26, 2015
@dulacp

dulacp commented Nov 27, 2015

Copy link
Copy Markdown
Contributor Author

Hey, thanks @jaysonsantos, for now I don't need a version bump, I can wait for a later release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants