Skip to content

add max to list of arithmetic operations #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steveoni merged 1 commit into from
Jan 24, 2022
+1 −1
Merged

add max to list of arithmetic operations #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add max to list of arithmetic operations
  • Loading branch information
@steveoni
steveoni committed Jan 22, 2022
commit 642731ffa16168b78c67ddd0d0937e619c00e4d6
2 changes: 1 addition & 1 deletion src/danfojs-base/aggregators/groupby.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ export default class Groupby {
private arithemetic(operation: {[key: string] : Array<string> | string} | string): { [key: string ]: {} } {

const opsName = [ "mean", "sum", "count", "mode", "std", "var", "cumsum", "cumprod",
"cummax", "cummin", "median" , "min"];
"cummax", "cummin", "median" , "min", "max"];
if (typeof operation === "string" ) {
if (!opsName.includes(operation)) {
throw new Error(`group operation: ${operation} is not valid`)
Expand Down