remove getString, which is not used, and was insecure to boot (WebAssembly#1966)

kripken · web-flow · commit 596ad8288827 · 2019-03-26T14:53:07.000-07:00
diff --git a/src/wasm-binary.h b/src/wasm-binary.h
@@ -962,7 +962,8 @@ class WasmBinaryBuilder {
 
   void read();
   void readUserSection(size_t payloadLen);
-  bool more() { return pos < input.size();}
+
+  bool more() { return pos < input.size(); }
 
   uint8_t getInt8();
   uint16_t getInt16();
@@ -979,7 +980,6 @@ class WasmBinaryBuilder {
   int64_t getS64LEB();
   Type getType();
   Type getConcreteType();
-  Name getString();
   Name getInlineString();
   void verifyInt8(int8_t x);
   void verifyInt16(int16_t x);
diff --git a/src/wasm/wasm-binary.cpp b/src/wasm/wasm-binary.cpp
@@ -862,14 +862,6 @@ Type WasmBinaryBuilder::getConcreteType() {
   return type;
 }
 
-Name WasmBinaryBuilder::getString() {
-  if (debug) std::cerr << "<==" << std::endl;
-  size_t offset = getInt32();
-  Name ret = cashew::IString((&input[0]) + offset, false);
-  if (debug) std::cerr << "getString: " << ret << " ==>" << std::endl;
-  return ret;
-}
-
 Name WasmBinaryBuilder::getInlineString() {
   if (debug) std::cerr << "<==" << std::endl;
   auto len = getU32LEB();
