Remove getString, which is not used, and was insecure to boot#1966
Merged
Conversation
jgravelle-google
approved these changes
Mar 26, 2019
jgravelle-google
left a comment
Contributor
There was a problem hiding this comment.
Woo codebase DCE
Out of curiosity, is the insecurity due to the lack of null-byte sanitation?
Member
|
@jgravelle-google a malformed module could claim the string has an arbitrarily large size, which could cause an out-of-bounds read. |
tlively
approved these changes
Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.