Skip to content

IMP: improve translation in 1-js/11-async/05-promise-api/article.md#909

Merged
leviding merged 3 commits intojavascript-tutorial:masterfrom
ClaraSchumann:patch-3
Jun 8, 2021
Merged

IMP: improve translation in 1-js/11-async/05-promise-api/article.md#909
leviding merged 3 commits intojavascript-tutorial:masterfrom
ClaraSchumann:patch-3

Conversation

@ClaraSchumann
Copy link
Copy Markdown
Contributor

翻译问题

目标章节:例如 1-js/01-getting-started/1-intro

当前上游最新 commit:此处填写本项目英文版 https://github.com/javascript-tutorial/en.javascript.info 的最新 commit,例如 b03ca00

本 PR 所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md a23882d 修改部分错误

注意,参考上游 commit 是指你所修改的文件,在英文仓库中同名文件的对应 commit,即你此次提交的修改的依据。如果本 PR 你只是提交一个文字或者语句优化,并非根据上游英文仓库的修改而提交的更新,则请填无。

翻译问题
Copy link
Copy Markdown
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR~这是我的修改意见,请看一下

Comment thread 1-js/11-async/05-promise-api/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@leviding leviding changed the title Update article.md IMP: improve translation in 1-js/11-async/05-promise-api/article.md Jun 5, 2021
@leviding
Copy link
Copy Markdown
Member

leviding commented Jun 5, 2021

@ClaraSchumann @MartinsYong 不小心 commit 了,有空的话麻烦看看我推的这个翻译哈~

Copy link
Copy Markdown
Contributor Author

@ClaraSchumann ClaraSchumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread 1-js/11-async/05-promise-api/article.md Outdated

````smart header="`Promise.all(iterable)` 允许在 `iterable` 中使用 non-promise 的“常规”值"
通常,`Promise.all(...)` 接受可迭代对象(iterable)的 promise(大多数情况下是数组)。但是,如果这些对象中的任意一个都不是 promise,那么它将被“按原样”传递给结果数组。
通常,`Promise.all(...)` 接受含有 promise 项的可迭代(iterable)对象作为参数。但是,如果这些对象中的任何一个不是 promise,那么它将被“按原样”传递给结果数组。
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文原文:Normally, Promise.all(...) accepts an iterable (in most cases an array) of promises. But if any of those objects is not a promise, it's passed to the resulting array "as is".

@leviding leviding merged commit ad706e6 into javascript-tutorial:master Jun 8, 2021
@leviding leviding added DONE and removed needs +1 labels Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants