Fix: minor typo error#809
Merged
leviding merged 2 commits intojavascript-tutorial:masterfrom Sep 21, 2020
Merged
Conversation
bemself
reviewed
Aug 8, 2020
| - `shift()` —— 从首端提取一个元素， | ||
| - `unshift(...items)` —— 向首端添加元素， | ||
| - `splice(pos, deleteCount, ...items)` —— 从 `index` 开始删除 `deleteCount` 个元素，并在当前位置插入 `items`。 | ||
| - `splice(index, deleteCount, ...items)` —— 从 `index` 开始删除 `deleteCount` 个元素，并在当前位置插入 `items`。 |
Collaborator
There was a problem hiding this comment.
@chhhhhhq 感谢提交~
参考最新的英文
en.javascript.info/article.md at master · javascript-tutorial/en.javascript.info:
splice(pos, deleteCount, ...items)-- at indexposdeletedeleteCountelements and insertitems.
个人建议和英文保持一致, 依然用 pos 作为参数, 修改后面的中文解释部分的翻译, 您觉得如何?
Contributor
Author
There was a problem hiding this comment.
嗯嗯,我觉得您的改动更好些
bemself
suggested changes
Sep 5, 2020
|
Please make the requested changes. After it, add a comment "/done". |
Co-authored-by: bemself <45781328+bemself@users.noreply.github.com>
MartinsYong
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RT.