Skip to content

Update files of 1-js/03-code-quality/05-testing-mocha#558

Merged
leviding merged 10 commits intomasterfrom
1-03-05
Dec 20, 2019
Merged

Update files of 1-js/03-code-quality/05-testing-mocha#558
leviding merged 10 commits intomasterfrom
1-03-05

Conversation

@leviding
Copy link
Copy Markdown
Member

@leviding leviding commented Dec 13, 2019

目标章节:1-js/03-code-quality/05-testing-mocha

当前上游最新 commit:javascript-tutorial/en.javascript.info@524d598

所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md javascript-tutorial/en.javascript.info@eeead38 更新译文
3-pow-test-wrong/solution.md javascript-tutorial/en.javascript.info@61910d1 更新译文
3-pow-test-wrong/task.md javascript-tutorial/en.javascript.info@0fcf9f8 更新译文
pow-2.view/index.html javascript-tutorial/en.javascript.info@bfa672d 同步上游
pow-4.view/test.js javascript-tutorial/en.javascript.info@7bc8404 同步上游
pow-full.view/test.js javascript-tutorial/en.javascript.info@b2e6ab2 同步上游
pow-nan.view/test.js javascript-tutorial/en.javascript.info@8311b44 同步上游

@javascript-translate-bot javascript-translate-bot requested a review from a team December 13, 2019 02:07
@leviding leviding added the WIP Work in process label Dec 13, 2019
@leviding leviding removed the WIP Work in process label Dec 19, 2019
Copy link
Copy Markdown
Collaborator

@bemself bemself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢翻译,校对完成~

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Outdated

[iframe height=250 src="pow-1" border=1 edit]

到目前为止,测试失败了,出现了一个错误。这是合乎逻辑的:我们在 `pow` 是一个空函数,因此 `pow(2,3)` 返回了 `undefined` 而不是 `8`。
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[我们在 pow 是一个空函数]
->
[我们的 pow 是一个空函数]

Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Outdated
Comment thread 1-js/03-code-quality/05-testing-mocha/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

leviding and others added 3 commits December 20, 2019 09:34
Co-Authored-By: bemself <45781328+bemself@users.noreply.github.com>
Co-Authored-By: bemself <45781328+bemself@users.noreply.github.com>
@leviding leviding merged commit 9c3993e into master Dec 20, 2019
@leviding leviding deleted the 1-03-05 branch December 20, 2019 01:49
@leviding
Copy link
Copy Markdown
Member Author

感谢 @bemself 校对,已修改完成 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants