Skip to content

4-binary/01-arraybuffer-binary-arrays/ sync with en#547

Merged
MartinsYong merged 2 commits intojavascript-tutorial:masterfrom
bemself:arraybuffer-54984506
Dec 10, 2019
Merged

4-binary/01-arraybuffer-binary-arrays/ sync with en#547
MartinsYong merged 2 commits intojavascript-tutorial:masterfrom
bemself:arraybuffer-54984506

Conversation

@bemself
Copy link
Copy Markdown
Collaborator

@bemself bemself commented Dec 5, 2019

目标章节:4-binary/01-arraybuffer-binary-arrays/

当前上游最新 commit:54984506

所做更改如下:

文件名 参考上游 commit 更改(理由)
article.md 54984506 更新英文改动部分

@bemself
Copy link
Copy Markdown
Collaborator Author

bemself commented Dec 5, 2019

@Reviewer, fyi attached diff between commits (previous) e6ed86c (latest) 5498450

arraybuffer-en-diff.patch.txt

@MartinsYong MartinsYong self-assigned this Dec 9, 2019
Copy link
Copy Markdown
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

226 行下面还有新的内容需要添加

@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@MartinsYong
Copy link
Copy Markdown
Member

上游最新好像是 3ba28aa 🤔

@bemself
Copy link
Copy Markdown
Collaborator Author

bemself commented Dec 10, 2019

@MartinsYong 是的,你是怼的,我光考虑翻译文件了,疏忽了图片更新也该一起 sync 的。

漏掉的翻译已添加,图片也更新了,还请再 review 一下,谢谢!

/done

@MartinsYong MartinsYong merged commit 23a1ed3 into javascript-tutorial:master Dec 10, 2019
@leviding leviding added DONE and removed needs +1 labels Dec 11, 2019
@bemself bemself deleted the arraybuffer-54984506 branch December 15, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants