Skip to content

Sync with upstream @ e515f80a#527

Closed
javascript-translate-bot wants to merge 2386 commits intomasterfrom
sync-e515f80a
Closed

Sync with upstream @ e515f80a#527
javascript-translate-bot wants to merge 2386 commits intomasterfrom
sync-e515f80a

Conversation

@javascript-translate-bot
Copy link
Copy Markdown

This PR was automatically generated to merge changes from en.javascript.info at e515f80

Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.

Alternatively, you can close this PR and merge conflicting changes manually.

The following files have conflicts and may need updates of the translations:

Click to open a list of 616 files

To merge changes manually (instead of merging this PR):

  1. Add remote upstream that links to the English version (only needs to be done once)
    • git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
  2. Commit all current work locally and git checkout master
  3. Pull the recent changes from the English version:
    • git pull upstream master
  4. Deal with the conflicts. If a conflict touches a few lines, then just fix it. Otherwise, following commands can help:
    • Checkout your (translated) version of a file/folder at the given path (removes all upstream changes):
      • git checkout --ours <path>
    • See the diff, what changed in the upstream file since branches diverged:
      • git diff --word-diff master...upstream/master <path> (please note: three dots in the command)
    • Then you can examine the changes in upstream and add them manually
  5. When conflicts resolved, commit them and git push origin master

Please ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).

This PR will be closed and replaced with a new one in a few days.

paroche and others added 30 commits October 17, 2019 17:02
"an array", "filter out"
Changed 'XHTML' to 'in XML mode' in title to match contents. 'XHTML' isn't mentioned anywhere else in the article except in that title. So either change it to 'XML' or explain the relationship?
"...`1` for elements,`3` for text nodes, and a few others ..."
There has to be a scary CPU-intensive task here, otherwise the example wouldn't make sense. Hence the suppression of "can";
I have also removed "actually" because in this context it would be interpreted as "to your surprise", which is not the case here
Deleted the full-stop as it's one sentence only
Minor grammar; removed unnecessary semicolon; added (best practices) semicolon
Minor grammar fixes and suggestions
Update article.md
On first and second reading, I found this section very confusing. After looking up outerHTML on Mozilla and doing some tests, I came to understand what was being said (I think). Here I'm proposing some changes to, I hope, make it clearer (plus some little grammar changes).
"there's a lot" -> "there are a lot",
Wording on why use attribute vs classes question
"**and** more attributes...
paroche and others added 25 commits November 7, 2019 21:34
`null` if that's `offsetParent` -> `null` for `offsetParent`
"CSS width is useless at all." -> "CSS width is useless."

Could have also said "CSS width is of no use at all."
"starts to bug..." -> "becomes buggy..."

I am not aware of "bug" being used as a verb in IT, but if it is, this is the first time I recall seeing it, so I would say it's probably not common.

Anyway, using it as a verb kind of bugged me a little.
'from bottom scroll' -> 'to bottom scroll'
"how to..." -> "how do we..."
"find out" -> "find"
And an added "the": "**the** `<html>` tag".
'"pro" and "contra" -> 'pros and cons'.

'pros and cons' is a much more typical way of saying it. But "pro" and "contra" is interesting. I hadn't previously thought about what "cons" stood for, though now it seems obvious.

Also, punctuation change.
'work with event' -> 'work with events'
"but strongly" -> "but is strongly". "is strongly not recommended" is still a bit odd, though it's readable and totally understandable. Could maybe be changed to "but is strongly discouraged". Still, not bad as (now) is.
Remove extra "b" from "visible".
Move '=' out of backticks
Move '=' out of backticks. Take two.
'well-thought' -> 'well thought out'
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 6 committers have signed the CLA.

✅ iliakan
❌ lex111
❌ paroche
❌ dashaezhova
❌ embok345
❌ koala-lava
You have signed the CLA already but the status is still pending? Let us recheck it.

@leviding leviding deleted the sync-e515f80a branch November 25, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.