Update article.md#388
Merged
lycheeEng merged 1 commit intojavascript-tutorial:masterfrom Jul 7, 2019
Merged
Conversation
这里【默认值】知识块中有一处代码不应该翻译成中文，否则会与下文中提到的内容不一致不便于读者理解
Collaborator
|
请问这个 PR 是不是与 #387 冲突？因为那边是将函数里的 |
Contributor
Author
|
@lycheeEng 没错，这个与 #387 有冲突（但我不知识如何撤销它）。因为后来我仔细想了想，不应该将函数形参中的“no text given”翻译成中文，如果那样就应该将下面所以有包含“no text given”的翻译成中文，这样反而不便于初学者阅读，所以才在 #388 中将包含”无文本“的内含修改成“no text given”。 |
Member
|
@CNSDHH 小伙伴儿的几个 PR， @lycheeEng 你 Review 修改后确认没问题，你可以直接 merge 哈 |
Collaborator
|
@leviding 好哒~ |
Collaborator
Contributor
Author
|
@lycheeEng 好的 |
lycheeEng
approved these changes
Jul 7, 2019
Collaborator
|
已 merge，再次感谢！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这里【默认值】知识块中有一处代码不应该翻译成中文，否则会与下文中提到的内容不一致不便于读者理解