Skip to content

feat: translating 08-async-await#377

Merged
leviding merged 22 commits intojavascript-tutorial:masterfrom
savokiss:translate-1-js/11-async/08-async-await
Jul 13, 2019
Merged

feat: translating 08-async-await#377
leviding merged 22 commits intojavascript-tutorial:masterfrom
savokiss:translate-1-js/11-async/08-async-await

Conversation

@savokiss
Copy link
Copy Markdown
Contributor

@savokiss savokiss commented Jun 24, 2019

chapter: 1-js 11-async 08-async-await

@javascript-translate-bot javascript-translate-bot requested a review from a team June 24, 2019 07:19
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 24, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@leviding
Copy link
Copy Markdown
Member

leviding commented Jun 24, 2019

Thanks for PR ❤️

@MartinsYong
Copy link
Copy Markdown
Member

MartinsYong commented Jul 6, 2019

让你久等了。校对认领~

@leviding
Copy link
Copy Markdown
Member

leviding commented Jul 6, 2019

@MartinsYong 好的~

MartinsYong
MartinsYong suggested changes Jul 6, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

校对完成，感谢您的翻译~
/done

Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/01-rewrite-async/task.md Outdated
Comment thread 1-js/11-async/08-async-await/02-rewrite-async-2/task.md Outdated
Comment thread 1-js/11-async/08-async-await/02-rewrite-async-2/task.md Outdated
Comment thread 1-js/11-async/08-async-await/02-rewrite-async-2/solution.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Jul 6, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@MartinsYong
Copy link
Copy Markdown
Member

MartinsYong commented Jul 6, 2019

还有一个问题：这个PR原先的文章不是最新的。
怎么搞？ @leviding

@leviding
Copy link
Copy Markdown
Member

leviding commented Jul 6, 2019 •
edited
Loading

@MartinsYong 我大致看了下，差别是不是不太大，如果是的话，可以本 PR 先按照这个做。Merge 后，你是否感兴趣，可以提交一个根据最新英文内容的更新译文的 PR？

再就是，本项目在招募志愿者，管理员，如果感兴趣可以联系我，微信 517010193。

@MartinsYong
Copy link
Copy Markdown
Member

MartinsYong commented Jul 7, 2019

OK，没问题。这个PR完了之后我会再重新校对一下。

@leviding
Copy link
Copy Markdown
Member

leviding commented Jul 7, 2019

@savokiss 有空可以看下校对意见修改一下啦

@savokiss
Copy link
Copy Markdown
Contributor Author

savokiss commented Jul 7, 2019

@leviding 嗯嗯，好的~

@savokiss
Copy link
Copy Markdown
Contributor Author

savokiss commented Jul 9, 2019

/done

leviding
leviding reviewed Jul 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@leviding leviding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

细节要注意，再就是 try..catch 这个尊重原文吧

Comment thread 1-js/11-async/08-async-await/01-rewrite-async/solution.md Outdated
Comment thread 1-js/11-async/08-async-await/01-rewrite-async/solution.md Outdated
Comment thread 1-js/11-async/08-async-await/01-rewrite-async/solution.md Outdated
Comment thread 1-js/11-async/08-async-await/01-rewrite-async/task.md Outdated
Comment thread 1-js/11-async/08-async-await/02-rewrite-async-2/solution.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
savokiss and others added 9 commits July 10, 2019 22:40
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
204926f 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
42b217a 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
0acfb86 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
12f8427 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
30a5418 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
8053d13 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
0764001 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
f0aee77 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
@savokiss @leviding
Update 1-js/11-async/08-async-await/article.md
96c311b 
Co-Authored-By: LeviDing <imdingxuewen@gmail.com>
MartinsYong
MartinsYong suggested changes Jul 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还要一些问题需要您看一下
@savokiss

Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
Comment thread 1-js/11-async/08-async-await/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Jul 12, 2019

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@savokiss
Copy link
Copy Markdown
Contributor Author

savokiss commented Jul 12, 2019

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team July 12, 2019 12:59
MartinsYong
MartinsYong approved these changes Jul 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MartinsYong MartinsYong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK~

@leviding leviding merged commit 5285b16 into javascript-tutorial:master Jul 13, 2019
@leviding
Copy link
Copy Markdown
Member

leviding commented Jul 13, 2019

Thanks you all.

@leviding leviding added DONE and removed needs +1 labels Jul 13, 2019
@savokiss savokiss deleted the translate-1-js/11-async/08-async-await branch July 14, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leviding leviding leviding approved these changes

+1 more reviewer

@MartinsYong MartinsYong MartinsYong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@savokiss @CLAassistant @leviding @MartinsYong @javascript-translate-bot