Skip to content

1-js/03-code-quality/02-coding-style#36

Merged
leviding merged 3 commits intozh-hansfrom
transfer/coding-style
Apr 22, 2018
Merged

1-js/03-code-quality/02-coding-style#36
leviding merged 3 commits intozh-hansfrom
transfer/coding-style

Conversation

@linhe0x0
Copy link
Copy Markdown

@linhe0x0 linhe0x0 commented Apr 11, 2018

resolve #18

first draft
8a59a0a 
resolve #18
@linhe0x0 linhe0x0 changed the title 1-js/03-code-quality/02-coding-style [WIP] 1-js/03-code-quality/02-coding-style Apr 11, 2018
@leviding leviding mentioned this pull request Apr 12, 2018
Closed
@leviding leviding added the WIP Work in process label Apr 12, 2018
@linhe0x0 linhe0x0 changed the title [WIP] 1-js/03-code-quality/02-coding-style 1-js/03-code-quality/02-coding-style Apr 12, 2018
@linhe0x0 linhe0x0 removed the WIP Work in process label Apr 12, 2018
@linhe0x0 linhe0x0 self-assigned this Apr 12, 2018
@wzy816
Copy link
Copy Markdown

wzy816 commented Apr 21, 2018

@leviding 校对认领

wzy816
wzy816 reviewed Apr 21, 2018
View reviewed changes
Copy link
Copy Markdown

@wzy816 wzy816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost perfect

Comment thread 1-js/03-code-quality/02-coding-style/article.md Outdated
你也可以从网上下载一些风格规则然后扩展它们。查看 <http://eslint.org/docs/user-guide/getting-started> 以获得有关安装的更多详细信息。

Using a linter has a great side-effect: linters catch typos. For instance, when an undefined variable is accessed, a linter detects it and (if integrated with an editor) highlights it. In most cases that's a mistype. So we can fix it right ahead.
使用一个 linter 会有一些很棒的边际效用。Linters 可以捕捉错别字。例如，当一个 undefined 变量被访问时，linter 会检测出并把它高亮（如果和编辑器集成了）。在大多数情况下，这都是你打错啦。所以我们可以在一开始就解决它。
Copy link
Copy Markdown

@wzy816 wzy816 Apr 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

边际效用 => 副作用

Copy link
Copy Markdown

@wzy816 wzy816 Apr 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一开始就解决它 => 马上解决它

@wzy816
Copy link
Copy Markdown

wzy816 commented Apr 21, 2018

@leviding @sqrthree 校对完了

👌 fix: Adjust some words due to code review changes
f917f70 
Signed-off-by: sqrtthree <imsqrtthree@gmail.com>
@linhe0x0
Copy link
Copy Markdown
Author

linhe0x0 commented Apr 21, 2018

已调整。

@leviding leviding merged commit 85c524f into zh-hans Apr 22, 2018
@leviding
Copy link
Copy Markdown
Member

leviding commented Apr 22, 2018

@sqrthree 这里的两个文件是否要翻一下？ https://github.com/xitu/javascript-tutorial-en/tree/zh-hans/1-js/03-code-quality/02-coding-style/1-style-errors

@linhe0x0 linhe0x0 deleted the transfer/coding-style branch April 22, 2018 10:02
@linhe0x0 linhe0x0 mentioned this pull request Apr 22, 2018
Merged
@linhe0x0
Copy link
Copy Markdown
Author

linhe0x0 commented Apr 22, 2018

@leviding 翻译好了，在 #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leviding leviding leviding approved these changes

+1 more reviewer

@wzy816 wzy816 wzy816 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@linhe0x0 linhe0x0

Labels

翻译完成

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linhe0x0 @wzy816 @leviding