Skip to content

fix: typo in 03-string#1066

Merged
leviding merged 3 commits intojavascript-tutorial:masterfrom
printfinn:patch-1
Jul 1, 2022
Merged

fix: typo in 03-string#1066
leviding merged 3 commits intojavascript-tutorial:masterfrom
printfinn:patch-1

Conversation

@printfinn
Copy link
Copy Markdown
Contributor

@printfinn printfinn commented Jun 30, 2022 •
edited
Loading

目标章节：1-js/05-data-types/03-string/

本 PR 所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 无 Typo & Avoid confusion

@javascript-translate-bot javascript-translate-bot requested a review from a team June 30, 2022 04:34
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

songhn233
songhn233 suggested changes Jun 30, 2022
View reviewed changes
Comment thread 1-js/05-data-types/03-string/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented Jun 30, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@songhn233
Copy link
Copy Markdown
Member

songhn233 commented Jun 30, 2022

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

另外 CLA 签一下～

@leviding leviding changed the title Fix typo in 03-string fix: typo in 03-string Jun 30, 2022
@printfinn @leviding
Update 1-js/05-data-types/03-string/article.md
42bef2c 
Co-authored-by: LeviDing <imdingxuewen@gmail.com>
@leviding leviding merged commit 1a3679c into javascript-tutorial:master Jul 1, 2022
@printfinn printfinn deleted the patch-1 branch July 1, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leviding leviding leviding left review comments

+1 more reviewer

@songhn233 songhn233 songhn233 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@printfinn @CLAassistant @javascript-translate-bot @songhn233 @leviding