Skip to content

improve translation for 1-js/05-data-types/10-destructuring-assignment#1050

Merged
leviding merged 7 commits intojavascript-tutorial:masterfrom
stosSe4r:patch-1
May 22, 2022
Merged

improve translation for 1-js/05-data-types/10-destructuring-assignment#1050
leviding merged 7 commits intojavascript-tutorial:masterfrom
stosSe4r:patch-1

Conversation

@stosSe4r
Copy link
Copy Markdown
Contributor

@stosSe4r stosSe4r commented May 19, 2022

试着改动了一些用词，调整了一部分句子的结构

目标章节：1-js/05-data-types/10-destructuring-assignment

当前上游最新 commit：javascript-tutorial/en.javascript.info@246156d

本 PR 所做更改如下：

文件名 参考上游 commit 更改（理由）
article.md 无 参考英文版内容改进中文翻译

注意，参考上游 commit 是指你所修改的文件，在英文仓库中同名文件的对应 commit，即你此次提交的修改的依据。如果本 PR 你只是提交一个文字或者语句优化，并非根据上游英文仓库的修改而提交的更新，则请填无。

@stosSe4r
improve translation
4899fb7 
试着改动了一些用词，调整了一部分句子的结构
@javascript-translate-bot javascript-translate-bot requested a review from a team May 19, 2022 07:17
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@stosSe4r stosSe4r changed the title improve translation improve translation for 1-js/05-data-types/10-destructuring-assignment May 19, 2022
songhn233
songhn233 suggested changes May 19, 2022
View reviewed changes
Comment thread 1-js/05-data-types/10-destructuring-assignment/article.md Outdated
Comment thread 1-js/05-data-types/10-destructuring-assignment/article.md Outdated
Comment thread 1-js/05-data-types/10-destructuring-assignment/article.md Outdated
Comment thread 1-js/05-data-types/10-destructuring-assignment/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

javascript-translate-bot commented May 19, 2022

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

stosSe4r and others added 4 commits May 19, 2022 23:50
@stosSe4r @songhn233
Update 1-js/05-data-types/10-destructuring-assignment/article.md
c59b0a9 
Co-authored-by: Songhn <songhn233@gmail.com>
@stosSe4r @songhn233
Update 1-js/05-data-types/10-destructuring-assignment/article.md
35d169a 
Co-authored-by: Songhn <songhn233@gmail.com>
@stosSe4r @songhn233
Update 1-js/05-data-types/10-destructuring-assignment/article.md
7e8a940 
Co-authored-by: Songhn <songhn233@gmail.com>
@stosSe4r @songhn233
Update 1-js/05-data-types/10-destructuring-assignment/article.md
b6ebb20 
Co-authored-by: Songhn <songhn233@gmail.com>
@stosSe4r
Copy link
Copy Markdown
Contributor Author

stosSe4r commented May 19, 2022

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team May 19, 2022 15:51
songhn233
songhn233 approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@songhn233 songhn233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

leviding
leviding reviewed May 22, 2022
View reviewed changes
Comment thread 1-js/05-data-types/10-destructuring-assignment/article.md Outdated
@leviding leviding added question Further information is requested and removed needs +1 labels May 22, 2022
@stosSe4r @leviding
Update 1-js/05-data-types/10-destructuring-assignment/article.md
01952c1 
Co-authored-by: LeviDing <imdingxuewen@gmail.com>
@stosSe4r stosSe4r requested a review from leviding May 22, 2022 03:48
@leviding leviding merged commit c44af61 into javascript-tutorial:master May 22, 2022
@leviding leviding removed the question Further information is requested label May 22, 2022
@leviding leviding added DONE and removed needs +1 labels May 22, 2022
@stosSe4r stosSe4r deleted the patch-1 branch May 22, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leviding leviding leviding approved these changes

+1 more reviewer

@songhn233 songhn233 songhn233 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DONE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stosSe4r @CLAassistant @javascript-translate-bot @leviding @songhn233