Fix MSVC 15.9 (2017) warning C4866

Radoslav Atanasov · cdunn2001 · commit ccd077ffced4 · 2018-12-30T15:28:09.000-06:00
by changing operator[] param type from JSONCPP_STRING to const JSONCPP_STRING& for CharReaderBuilder and StreamWriterBuilder (as it is already in Value). https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c4866?view=vs-2017
diff --git a/include/json/reader.h b/include/json/reader.h
@@ -358,7 +358,7 @@ class JSON_API CharReaderBuilder : public CharReader::Factory {
 
   /** A simple way to update a specific setting.
    */
-  Value& operator[](JSONCPP_STRING key);
+  Value& operator[](const JSONCPP_STRING& key);
 
   /** Called by ctor, but you can use this to reset settings_.
    * \pre 'settings' != NULL (but Json::null is fine)
diff --git a/include/json/writer.h b/include/json/writer.h
@@ -132,7 +132,7 @@ class JSON_API StreamWriterBuilder : public StreamWriter::Factory {
   bool validate(Json::Value* invalid) const;
   /** A simple way to update a specific setting.
    */
-  Value& operator[](JSONCPP_STRING key);
+  Value& operator[](const JSONCPP_STRING& key);
 
   /** Called by ctor, but you can use this to reset settings_.
    * \pre 'settings' != NULL (but Json::null is fine)
diff --git a/src/lib_json/json_reader.cpp b/src/lib_json/json_reader.cpp
@@ -1969,7 +1969,7 @@ bool CharReaderBuilder::validate(Json::Value* invalid) const {
   }
   return 0u == inv.size();
 }
-Value& CharReaderBuilder::operator[](JSONCPP_STRING key) {
+Value& CharReaderBuilder::operator[](const JSONCPP_STRING& key) {
   return settings_[key];
 }
 // static
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
@@ -1145,7 +1145,7 @@ const Value& Value::operator[](const char* key) const {
     return nullSingleton();
   return *found;
 }
-Value const& Value::operator[](JSONCPP_STRING const& key) const {
+Value const& Value::operator[](const JSONCPP_STRING& key) const {
   Value const* found = find(key.data(), key.data() + key.length());
   if (!found)
     return nullSingleton();
diff --git a/src/lib_json/json_writer.cpp b/src/lib_json/json_writer.cpp
@@ -1231,7 +1231,7 @@ bool StreamWriterBuilder::validate(Json::Value* invalid) const {
   }
   return 0u == inv.size();
 }
-Value& StreamWriterBuilder::operator[](JSONCPP_STRING key) {
+Value& StreamWriterBuilder::operator[](const JSONCPP_STRING& key) {
   return settings_[key];
 }
 // static

Original file line number	Diff line number	Diff line change
`@@ -1969,7 +1969,7 @@ bool CharReaderBuilder::validate(Json::Value* invalid) const {`
`1969`	`1969`	`}`
`1970`	`1970`	`return 0u == inv.size();`
`1971`	`1971`	`}`
`1972`		`-Value& CharReaderBuilder::operator[](JSONCPP_STRING key) {`
	`1972`	`+Value& CharReaderBuilder::operator[](const JSONCPP_STRING& key) {`
`1973`	`1973`	`return settings_[key];`
`1974`	`1974`	`}`
`1975`	`1975`	`// static`
Original file line number	Diff line number	Diff line change
`@@ -1145,7 +1145,7 @@ const Value& Value::operator[](const char* key) const {`
`1145`	`1145`	`return nullSingleton();`
`1146`	`1146`	`return *found;`
`1147`	`1147`	`}`
`1148`		`-Value const& Value::operator[](JSONCPP_STRING const& key) const {`
	`1148`	`+Value const& Value::operator[](const JSONCPP_STRING& key) const {`
`1149`	`1149`	`Value const* found = find(key.data(), key.data() + key.length());`
`1150`	`1150`	`if (!found)`
`1151`	`1151`	`return nullSingleton();`
Original file line number	Diff line number	Diff line change
`@@ -1231,7 +1231,7 @@ bool StreamWriterBuilder::validate(Json::Value* invalid) const {`
`1231`	`1231`	`}`
`1232`	`1232`	`return 0u == inv.size();`
`1233`	`1233`	`}`
`1234`		`-Value& StreamWriterBuilder::operator[](JSONCPP_STRING key) {`
	`1234`	`+Value& StreamWriterBuilder::operator[](const JSONCPP_STRING& key) {`
`1235`	`1235`	`return settings_[key];`
`1236`	`1236`	`}`
`1237`	`1237`	`// static`