PERF: Replace explicit return calls of constructor

hjmjohnson · cdunn2001 · commit 4abf4ec20823 · 2018-12-30T15:26:29.000-06:00
Replaces explicit calls to the constructor in a return with a braced
initializer list. This way the return type is not needlessly duplicated in the
function definition and the return statement.

SRCDIR=/Users/johnsonhj/src/jsoncpp #My local SRC
BLDDIR=/Users/johnsonhj/src/jsoncpp/cmake-build-debug/ #My local BLD

cd /Users/johnsonhj/src/jsoncpp/cmake-build-debug/
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-return-braced-init-list  -header-filter=.* -fix
diff --git a/src/lib_json/json_reader.cpp b/src/lib_json/json_reader.cpp
@@ -69,7 +69,7 @@ Features::Features()
     : allowComments_(true), strictRoot_(false),
       allowDroppedNullPlaceholders_(false), allowNumericKeys_(false) {}
 
-Features Features::all() { return Features(); }
+Features Features::all() { return {}; }
 
 Features Features::strictMode() {
   Features features;
@@ -906,7 +906,7 @@ class OurFeatures {
 // exact copy of Implementation of class Features
 // ////////////////////////////////
 
-OurFeatures OurFeatures::all() { return OurFeatures(); }
+OurFeatures OurFeatures::all() { return {}; }
 
 // Implementation of class Reader
 // ////////////////////////////////
diff --git a/src/lib_json/json_value.cpp b/src/lib_json/json_value.cpp
@@ -1507,7 +1507,7 @@ Value::const_iterator Value::begin() const {
   default:
     break;
   }
-  return const_iterator();
+  return {};
 }
 
 Value::const_iterator Value::end() const {
@@ -1520,7 +1520,7 @@ Value::const_iterator Value::end() const {
   default:
     break;
   }
-  return const_iterator();
+  return {};
 }
 
 Value::iterator Value::begin() {

Original file line number	Diff line number	Diff line change
`@@ -1507,7 +1507,7 @@ Value::const_iterator Value::begin() const {`
`1507`	`1507`	`default:`
`1508`	`1508`	`break;`
`1509`	`1509`	`}`
`1510`		`- return const_iterator();`
	`1510`	`+ return {};`
`1511`	`1511`	`}`
`1512`	`1512`
`1513`	`1513`	`Value::const_iterator Value::end() const {`
`@@ -1520,7 +1520,7 @@ Value::const_iterator Value::end() const {`
`1520`	`1520`	`default:`
`1521`	`1521`	`break;`
`1522`	`1522`	`}`
`1523`		`- return const_iterator();`
	`1523`	`+ return {};`
`1524`	`1524`	`}`
`1525`	`1525`
`1526`	`1526`	`Value::iterator Value::begin() {`