Skip to content

Fix WordCounterSpliterator.tryAdvance #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uprem wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix WordCounterSpliterator.tryAdvance #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix WordCounterSpliterator.tryAdvance 
fixes:
1. when initial string is empty, prevents throwing StringIndexOutOfBoundsException
2. the last valid iteration return true. old code returns false for the last character which breaks tryAdvance() specs
  • Loading branch information
@uprem
uprem authored Sep 10, 2016
commit 931f17e3435207ea97336bd230ac92f160a6073e
8 changes: 6 additions & 2 deletions src/main/java/lambdasinaction/chap7/WordCount.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,12 @@ private WordCounterSpliterator(String string) {

@Override
public boolean tryAdvance(Consumer<? super Character> action) {
action.accept(string.charAt(currentChar++));
return currentChar < string.length();
if(currentChar < string.length()) {
action.accept(string.charAt(currentChar++));
return true;
} else {
return false;
}
}

@Override
Expand Down