Skip to content

Modern I/O article (issue #26)#66

Merged
carimura merged 6 commits into
mainfrom
modern-io
Apr 25, 2024
Merged

Modern I/O article (issue #26)#66
carimura merged 6 commits into
mainfrom
modern-io

Conversation

@cayhorstmann

Copy link
Copy Markdown
Collaborator

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 1, 2024
@cayhorstmann cayhorstmann mentioned this pull request Feb 2, 2024

@danthe1st danthe1st left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few suggestions.
These are just suggestions, I am just an outside user interested in this repo.

Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated

@danthe1st danthe1st left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found other minor things that may still be worth considering.

Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated

@danthe1st danthe1st left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your article and your changes to it. I think it turned out great.

@nipafx nipafx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Cay. 👋🏾 Looks good but there are a few small fixes to make. I proposed many of them below.

Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/index.md Outdated
@carimura

Copy link
Copy Markdown
Contributor

@cayhorstmann sorry for the delay, let's get this merged! What does everyone think about making this article the 5th in the I/O series [1]?

[1] https://dev.java/learn/java-io/

@danthe1st

danthe1st commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

I think it might be weird to have that article after Putting it All Together.
Maybe Putting it All Together should be adapted to also contain something from this article and put this article before?

Also, I just realized that the file here is just called index.md and doesn't have any metadata.

@carimura

Copy link
Copy Markdown
Contributor

I've already fixed the metadata locally. Just need a place to put the tutorial. We are leaning away from the series now.

@carimura

carimura commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

ok we're considering some possible content reorg strategies but for now I'm thinking keep it where it's at: "Mastering the API" section as its own article, not as part of the I/O series.

@carimura

Copy link
Copy Markdown
Contributor

ok metadata added, ready for merge here cc @cayhorstmann @ammbra @JosePaumard.

@carimura carimura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- looking for one more review from Java team on organization

@danthe1st

Copy link
Copy Markdown
Contributor

ok we're considering some possible content reorg strategies but for now I'm thinking keep it where it's at: "Mastering the API" section as its own article, not as part of the I/O series.

Should there be a table of contents?

@carimura

Copy link
Copy Markdown
Contributor

TOC should automatically build itself when missing

Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/01_modern_io.md Outdated
Comment thread app/pages/learn/01_tutorial/04_mastering-the-api/02_modern_io/01_modern_io.md Outdated
@carimura carimura merged commit a5166d8 into main Apr 25, 2024
@carimura

Copy link
Copy Markdown
Contributor

boom thanks all!

@carimura carimura deleted the modern-io branch April 25, 2024 14:20
@carimura carimura restored the modern-io branch April 25, 2024 14:20
@nipafx

nipafx commented May 17, 2024

Copy link
Copy Markdown
Contributor

Thanks for finishing this, guys! 👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants