Skip to content

Handle 204 response code for patch operation.#17882

Merged
dkocher merged 2 commits intomasterfrom
bugfix/MD-26702
Feb 17, 2026
Merged

Handle 204 response code for patch operation.#17882
dkocher merged 2 commits intomasterfrom
bugfix/MD-26702

Conversation

@dkocher
Copy link
Copy Markdown
Contributor

@dkocher dkocher commented Feb 13, 2026

No description provided.

@dkocher dkocher added this to the 9.4 milestone Feb 13, 2026
@dkocher dkocher requested a review from a team as a code owner February 13, 2026 18:27
@dkocher dkocher added the onedrive OneDrive Protocol Implementation label Feb 13, 2026
@AliveDevil
Copy link
Copy Markdown
Contributor

This prevents throwing the error into users face.
However, Microsoft OneDrive Consumer fails to handle the patch request to PATCH v1.0/drives/{driveId}/items/{itemId} (as the recommended way of calling that endpoint), but it works fine with the undocumented way of specifying the target file in PATCH v1.0/drives/{driveId}/root:/path/to/file.
Effectively, when receiving an Optional.empty() assume that the rename operation failed.

Repro with MSGraph Sdk Java and ticket with Microsoft pending.

Copy link
Copy Markdown
Contributor

@AliveDevil AliveDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this.
There were discussions about disabling Move/Timestamp feature for the next release, which would require releasing a new version in the future, when this starts working again.

@dkocher dkocher merged commit 42da9e9 into master Feb 17, 2026
5 checks passed
@dkocher dkocher deleted the bugfix/MD-26702 branch February 17, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

onedrive OneDrive Protocol Implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants