Repository navigation
Fix #3930: Add tests for the host-target APX override - #4015
Draft
claude[bot] wants to merge 3 commits into
Draft
claude[bot] wants to merge 3 commits into
claude[bot] wants to merge 3 commits into
Conversation
Add developer options --mock-host-target=<target> and --mock-host-os-apx=on|off so tests can supply the detected host target and the OS APX state, and print the effective APX features (Target::getEnabledAPXFeatures()) in --print-target for APX-capable targets. Add a lit test that checks the override for NVL and DMR: host selection with OS APX off disables all APX features, even with a partial --opt=disable-apx mask; with OS APX on, or with an explicitly named target or --cpu, the backend defaults are kept minus the user mask. Co-authored-by: aneshlya <2833813+aneshlya@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
Collaborator
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Document which target family to use for AMD Zen 4/5/6 and Intel Sapphire Rapids, Granite Rapids, Diamond Rapids and Nova Lake, the default target each --cpu selects, --cpu/--target compatibility, and the multi-target rules: one target per ISA family, no --cpu, dispatch order, AMX gating and the missing OS APX check. Gang sizes are documented as defaults only, not as performance recommendations (discussion #3827). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
--mock-host-target now rejects non-x86 targets, and --mock-host-os-apx warns that it is ignored on non-x86 hosts. The target guide keeps only user-visible facts that are not documented elsewhere and links to the existing APX, AMX and multi-target documentation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3930
--mock-host-target=<target>and--mock-host-os-apx=on|off(listed under--help-dev) so tests can supply the detected host target and OS APX state without NVL/DMR hardware. Both only affect host target selection; an explicit--targetor--cpuignores them.Target::getEnabledAPXFeatures()) in--print-targetfor x86-64 APX-capable targets (Target APX Features: <list>|none).tests/lit-tests/host-apx-os-state.ispccovering NVL and DMR:--opt=disable-apx=egprmask: all APX features disabled;--cpuwith OS APX off: backend defaults kept, minus the user mask;--mock-host-targetvalue is rejected.The test fails if
m_disabledAPX |= Opt::APX_allis removed. Lit tests pass locally with LLVM 23.1. The test requiresLLVM_22_0+; the expected default APX list on LLVM 22 (withoutjmpabs) has not been verified.🤖 Generated with Claude Code