Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c161bdc to
400ace9
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Lines 46 to 50 in 400ace9
The ISA enum now assigns NVL_AVX10_2=11 and DMR_AVX10_2=12, but isa_strings still ends at "DMR" without an entry for NVL and only contains 12 elements. lGetSystemISA() indexes this array with isa_id from get_x86_isa(), so NVL will be reported as DMR and DMR (index 12) reads past the end of the array, which can yield garbage or crash the check_isa helper used by scripts/alloy to detect the host ISA.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
022bdb1 to
f48b7d9
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f48b7d99a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- NVL inherits from ICL instead of DMR (NVL is DMR without AMX) - Add conditional AMX capabilities for DMR targets only - Rename target-fp16-*-common.ll to target-avx512fp16-*-common.ll - Fix NVL detection in isa.h (remove prefetchi check) - Fix ISAToString to use consistent underscore format (avx10_2nvl) - Fix check_dispatch_llvm22_plus.ispc return values - Fix check_isa.cpp to only show AMX status for AMX-capable ISAs
Description
Brief description of changes
Related Issue
Checklist
clang-format(e.g.,clang-format -i src/ispc.cpp)