Repository navigation
Add double-pumped neon targets: neon-i8x32 and neon-i16x16 - #3188
Merged
Merged
Conversation
aneshlya
requested review from
dbabokin and
nurmukhametov
and removed request for
nurmukhametov
January 23, 2025 19:29
aneshlya
force-pushed
the
neon-double-pumped
branch
from
January 23, 2025 23:44
acabe15 to
ad17645
Compare
dbabokin
approved these changes
Jan 23, 2025
dbabokin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Don't forget to update ISPC Development Guide with new SHAs after you merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two double-pumped neon targets.
Completes implementation for #3167.
This PR can be used as a "How to add a new target" example together with docs in
ISPC Development Guide