add internal-apis to package.json's files#2036
Open
funkjk wants to merge 3 commits intoisomorphic-git:mainfrom
Open
add internal-apis to package.json's files#2036funkjk wants to merge 3 commits intoisomorphic-git:mainfrom
funkjk wants to merge 3 commits intoisomorphic-git:mainfrom
Conversation
Member
|
Hm. Now I'm wondering maybe better would be creating a different library with the internals. Maybe This will require some work (creating a project, moving unit tests over, adding GitHub actions), but if you want to use the internals, you will not need to install What do you think? You want to use this API, maybe you can contribute a bit more to the project. |
Author
|
Your idea is better if there are many libraries that refer internal-apis. And moving internal-apis to other project is expensive, but deviding get little benefit . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To call internal-api outside library, add internal-api.xx to package.json.
#2032
I'm fixing a bug or typo
npm run add-contributorand follow the prompts to add yourself to the READMEI'm adding a parameter to an existing command X:
src/api/X.js(andsrc/commands/X.jsif necessary)__tests__/test-X.jsif possiblenpm run add-contributorand follow the prompts to add yourself to the READMEI'm adding a new command:
src/api(andsrc/commandsif necessary)src/index.js__tests__/test-exports.jssrc/__tests__website/sidebars.jsonwebsite/versioned_sidebars/version-1.x-sidebars.jsonnpm run add-contributorand follow the prompts to add yourself to the README