security: Fix js/file-system-race (CWE-367) security issue#444
Closed
fabasoad wants to merge 2 commits intoisaacs:mainfrom
fabasoad:fix/security
Closed
security: Fix js/file-system-race (CWE-367) security issue#444fabasoad wants to merge 2 commits intoisaacs:mainfrom fabasoad:fix/security
js/file-system-race (CWE-367) security issue#444fabasoad wants to merge 2 commits intoisaacs:mainfrom
fabasoad:fix/security
Conversation
Owner
|
Hm, there actually is still an unavoidable TOCTOU here, but this patch make the failure mode match the failure mode of the asynchronous case and the behavior of extract (ie, any data added to the file after the |
Contributor
|
See #445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes
js/file-system-racesecurity issue found by CodeQL inlist.tsfile.Verification
Before fix
git checkout main codeql database create .db-codeql --language=javascript --build-mode=none codeql database analyze .db-codeql javascript-security-extended.qls --format=sarifv2.1.0 --output=codeql.sarif jq -r '.runs[].results[] | "\(.ruleId): \(.locations[].physicalLocation.artifactLocation.uri)"' codeql.sarifAfter fix
References