Initial commit#8
Closed
michellebro wants to merge 2 commits into
Closed
Conversation
Author
|
Our project |
Closed
MarySueMe
pushed a commit
to MarySueMe/lab-javascript-basic-algorithms
that referenced
this pull request
May 12, 2023
Sandra, there was a merge conflict due to the renaming of the test spec file, I resolved it locally. I like the addition of the bonus iterations. I find both a considerably harder than the rest. I added an extra bit of clarification regarding how values of different types should be added up. Do you think we should instruct students to not do them in the normal flow of the lab, and only tackle them at the end? Could we ponder moving them to the end of the lab? Additionally, I split the last iteration and passed the requirement to calculate the products diagonally to an extra iteration, ironhack-labs#8.1, since my current cohort found it significantly more complex to solve than horizontally and diagonally. Specs don't include any tests for the diagonal product. I'm merging this the PR into master, but I think that it would be productive to follow up on this Lab and do some additional work on it. Cheers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work by Juan and Michelle