[BRL-FT-01.2020_VICTORIA_BLATKOWSKA&ELSA FILLIPIDOU] #634
Closed
VictoriaBlat wants to merge 1 commit into
Closed
Conversation
itstheandre
reviewed
Jan 7, 2020
|
|
||
| let hacker1 = "Victoria"; | ||
|
|
||
| console.log(`"The driver's name is ${hacker1}."`); |
There was a problem hiding this comment.
In this case and in the hacker2 version the double quotes are unnecessary :) the backticks are already giving you a string. :)
itstheandre
reviewed
Jan 7, 2020
| let arrayCounter = splitted.length; | ||
|
|
||
| console.log(arrayCounter); | ||
| console.log("'et' appears " + loremIpsum.match(/et/g).length + " times."); |
There was a problem hiding this comment.
You didn't need to use any Regex , but nicely done!
itstheandre
reviewed
Jan 7, 2020
itstheandre
left a comment
There was a problem hiding this comment.
Great job!!
Keep up the good work :)
|
@itstheandre thanks for the review! 🤓 |
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is closed. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First Lab