Skip to content

ING-Alina-Jürgen-Sergej #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JueGooss wants to merge 4 commits into from
Closed

ING-Alina-Jürgen-Sergej #575

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a265bd7
First push
Nov 18, 2019
8c32f57
First iteration done
Nov 18, 2019
f67e129
Second iteration done
Nov 18, 2019
f05ded3
Third iteration done
Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 116 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
/*Iteration 1: Names and Input
1.1 Create a variable hacker1 with the driver's name.*/
let hacker1 = "Juergen";


//1.2 Print "The driver's name is XXXX".//

console.log(`The driver´s name is ${hacker1}`);

//1.3 Create a variable hacker2 with the navigator's name.//

let hacker2 = "AlinaSergej";
/*Iteration 1: Names and Input
1.1 Create a variable hacker1 with the driver's name.*/
let hacker1 = "Juergen";


//1.2 Print "The driver's name is XXXX".//

console.log(`The driver´s name is ${hacker1}`);

//1.3 Create a variable hacker2 with the navigator's name.//

let hacker2 = "AlinaSergej";

//1.4 Print "The navigator's name is YYYY".//

console.log(`The navigator´s name is ${hacker2}`);

/*Iteration 2: Conditionals
2.1. Depending on which name is longer, print: - The Driver has the longest name, it has XX characters or - Yo, navigator got the longest name, it has XX characters or - Wow, you both got equally long names, XX characters!*/

if (hacker1.length >=hacker2.length){
Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be greatly simplified by extracting the condition as an expression to use in the if else branching

if (hacker1.length == hacker2.length){
console.log(`Wow, you both got equally long names, ${hacker1.length} characters!`)
} else {
console.log(`The Driver has the longest name, it has ${hacker1.length} characters`)
}
} else {
Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer an explicit condition. see above comment

console.log(`Yo, navigator got the longest name, it has ${hacker2.length} characters`)
}

/*Iteration 3: Loops
3.1 Print all the characters of the driver's name, separated by a space and in capitals i.e. "J O H N"*/

Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer use of loops as per lesson instruction

let uppercasedDriver=hacker1.toUpperCase();
/*let split="";
. Solution:
for (let i = 0; i<hacker1.length; i++){
split += `${uppercasedDriver[i]} `;

}
console.log(split);*/

let splittedName = uppercasedDriver.split("");
Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for native string methods prefer method concatenation

let nameFinal = splittedName.join(" ")
console.log(nameFinal)

//3.2 Print all the characters of the navigator's name, in reverse order. i.e. "nhoJ"//


let reversedName = hacker2.split("").reverse().join("")
Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer loops as per lesson instructions

console.log(reversedName)

//3.3 Depending on the lexicographic order of the strings, print: - The driver's name goes first. - Yo, the navigator goes first definitely. - What?! You both got the same name?//

let abc = "abcdefghijklmnopqrstuvwxyz";
Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: this is not the correct solution because it does not respect the lexicographic order

let firstLetterHacker1 = hacker1[0];
let firstLetterHacker2 = hacker2[0];
if (abc.indexOf(firstLetterHacker1) < abc.indexOf(firstLetterHacker2)){
if(abc.indexOf(firstLetterHacker1) == abc.indexOf(firstLetterHacker2)){
console.log("Both have the same first letter");
} else {
console.log(`${hacker1} goes first`);
}
}
else{
console.log(`${hacker2} goes first`);
}

/*Bonus Time!
Go to lorem ipsum generator and:

Generate 3 paragraphs. Store the text in a variable type of string.
Make your program count the number of words in the string.
Make your program count the number of times the Latin word et appears.*/
//1.4 Print "The navigator's name is YYYY".//

console.log(`The navigator´s name is ${hacker2}`);

/*Iteration 2: Conditionals
2.1. Depending on which name is longer, print: - The Driver has the longest name, it has XX characters or - Yo, navigator got the longest name, it has XX characters or - Wow, you both got equally long names, XX characters!*/

if (hacker1.length >=hacker2.length){
if (hacker1.length == hacker2.length){
console.log(`Wow, you both got equally long names, ${hacker1.length} characters!`)
} else {
Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer explicit condition

console.log(`The Driver has the longest name, it has ${hacker1.length} characters`)
}
} else {
Copy link
Copy Markdown

@MarcoSantonastasi MarcoSantonastasi Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer explicit condition

console.log(`Yo, navigator got the longest name, it has ${hacker2.length} characters`)
}

/*Iteration 3: Loops
3.1 Print all the characters of the driver's name, separated by a space and in capitals i.e. "J O H N"*/

//3.2 Print all the characters of the navigator's name, in reverse order. i.e. "nhoJ"//

//3.3 Depending on the lexicographic order of the strings, print: - The driver's name goes first. - Yo, the navigator goes first definitely. - What?! You both got the same name?//

/*Bonus Time!
Go to lorem ipsum generator and:

Generate 3 paragraphs. Store the text in a variable type of string.
Make your program count the number of words in the string.
Make your program count the number of times the Latin word et appears.*/