You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall, easy difficulty, with a single exception, i have 2 "undefined+string" concatenated when outputing the two names (driver and navigator) on console. I haven't investigated it deeply.
Buen trabajo Dani, el ejercicio está completo y bien resuelto.
Me ha gustado mucho que hayas creado funciones para resolver las diferentes iteraciones y el uso de expresiones regulares. Quizá el nombre de los parámetros de las funciones deberían ser más genéricos ya que en este ejercicio tiene sentido que se llamen driverName y navigatorName pero al fin y al cabo invertir dos strings puede ser algo que utilices en otros ejercicios y si estos parámetros se llaman name1 y name2 por ejemplo será más genérico.
Sigue trabajando así e intenta incluir el .gitignore en los proyectos que como hemos hablado en clase es una buena práctica.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First and second iterations,
Missed to add the first commit correctly, due to the description name, sorry.