Skip to content

[SAO FT3 - PP - W1D3] Arthur S e Dax Oliveira#374

Closed
arthsan wants to merge 1 commit into
ironhack-labs:masterfrom
arthsan:master
Closed

[SAO FT3 - PP - W1D3] Arthur S e Dax Oliveira#374
arthsan wants to merge 1 commit into
ironhack-labs:masterfrom
arthsan:master

Conversation

@arthsan
Copy link
Copy Markdown

@arthsan arthsan commented Mar 29, 2019

No description provided.

@henriquegmendes
Copy link
Copy Markdown

#checked

Boa!! Algumas observações somente:

  • No exercício de verificar qual nome vem primeiro há uma falha na lógica caso os dois nomes sejam exatamente iguais :-)
  • No exercício de contar quantos ''et"s existem no texto, há uma pequena falha na contagem (ela não está contando uma string que contém "et,", por exemplo). Ai invés de comparar usando o sinal de "===", tentem utilizar o método "includes" ;-)

Keep going!!!!!

@stale
Copy link
Copy Markdown

stale Bot commented Dec 17, 2019

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Dec 17, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Dec 19, 2019

This pull request is closed. Thank you.

@stale stale Bot closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants