Skip to content

BCN-WDFT-Miguel&Jesus#340

Closed
Jeuxseh wants to merge 1 commit into
ironhack-labs:masterfrom
Jeuxseh:master
Closed

BCN-WDFT-Miguel&Jesus#340
Jeuxseh wants to merge 1 commit into
ironhack-labs:masterfrom
Jeuxseh:master

Conversation

@Jeuxseh
Copy link
Copy Markdown

@Jeuxseh Jeuxseh commented Feb 5, 2019

Copy link
Copy Markdown
Contributor

@tawebbcn tawebbcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buen trabajo!

@@ -1,7 +1,35 @@
// Names and Input

let hacker1 = "Jesús";
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si son variables que no cambiarán es mejor utilizar const en vez de let.
Como regla general: Siempre utilizar const hasta que el código de error.


// Lorem ipsum generator
let string1 = "";
for(let i = 0; i<=hacker1.length-1;i++){
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si utilizáis espacios entre los operadores (let i = 0) utilizarlo para todos (i<=hacker1.length-1)

@stale
Copy link
Copy Markdown

stale Bot commented Dec 17, 2019

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Dec 17, 2019
@stale
Copy link
Copy Markdown

stale Bot commented Dec 19, 2019

This pull request is closed. Thank you.

@stale stale Bot closed this Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants