Paris - Estelle & KevinM #300
Closed
KevGhub wants to merge 1 commit into
Closed
Conversation
ta-web-paris
reviewed
Jan 8, 2019
| console.log("wow, you both got equally long names, " + hacker2.length + "characters!!"); | ||
| }; | ||
|
|
||
| var UpperCase = "" |
There was a problem hiding this comment.
you didn't quiet finish this bit- you're not making it uppercase (yet)
you could either make it uppercase on each iteration, or do it after the loop on the final string
|
What you have done is good! If you want to continue, let us know and we can give you some more feedback once you've done it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, no time for Bonus