paris-christian-jeannicolas#230
Closed
blksnk wants to merge 1 commit into
Closed
Conversation
| var str2; | ||
| for (var i = 0; i <= (hacker2.length - 1); i++) { | ||
| str2 += hacker2[i]; | ||
| }; |
There was a problem hiding this comment.
This for loop is not really needed, it is the same thing of doing :
var str2 = hacker2;
|
Good job !! Conditions, loops and string methods seem well understood ! |
| } | ||
| else { | ||
| console.log("What?! You both got the same name?"); | ||
| }; |
There was a problem hiding this comment.
In the first big if statement, to check if they have the same name, you are only comparing the first letter of each name. To be sure your code also works if there names start with the same letter but have different names, you can write your code like that :
if (hacker1 === hacker2){
console.log("What?! You both got the same name?");
} else if (names[0] === hacker1) {
console.log("The driver's name goes first");
} else {
console.log("Yo, the navigator goes first definitely");
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tidochrys