Paris - Geoffroy & Adèle #223
Closed
AdeleRevert wants to merge 1 commit into
Closed
Conversation
| var hacker2 = prompt("What's the navigator's name?"); | ||
| console.log("The navigator's name is " + hacker2); | ||
|
|
||
| var shortestName = ""; |
There was a problem hiding this comment.
You don't really need this variable, (also in line 12, 16, 20 and 24) but the logics is perfect anyway :)
|
Great job! you already manage to find different solutions to execute a task, you seem to have understood well loops, conditions and string methods! Keep up the good work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@geoffroybag