PAR John & Luca - #182
Closed
johndimitroff wants to merge 1 commit into
Closed
Conversation
ta-web-paris
reviewed
Aug 7, 2018
|
|
||
| //var hacker2 = prompt("What is your name?") | ||
| var hacker2 = "Luca" | ||
| console.log("The driver's name is " + hacker2); |
There was a problem hiding this comment.
You can ask the user to enter a name himself by using "prompt" :
var hacker2 = prompt("What's your name ? ")
ta-web-paris
reviewed
Aug 7, 2018
| function isPalindrome(str){ | ||
|
|
||
| // lower the case | ||
| var string = str.toLowerCase() |
There was a problem hiding this comment.
As a good practice, it is better not to call a variable my the name of a JS type name, you can use for intance "myString" instead of "string" :)
ta-web-paris
reviewed
Aug 7, 2018
| } | ||
|
|
||
| isPalindrome('a man, a plan, a canal, Panama!') | ||
| isPalindrome('john') |
There was a problem hiding this comment.
Great job ! Efficient, very clear and you take care of cleaning the string.
again you can check the prompt function to ask the user to enter an expression :)
|
Well done, great job! 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lucamerzi